Skip site navigation (1) Skip section navigation (2)

Re: Re: [COMMITTERS] pgsql: Send new protocol keepalive messages to standby servers.

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: Simon Riggs <simon(at)2ndquadrant(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Re: [COMMITTERS] pgsql: Send new protocol keepalive messages to standby servers.
Date: 2012-01-13 04:18:40
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgsql-committerspgsql-hackers
On Fri, Jan 13, 2012 at 4:19 AM, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
> On Thu, Jan 12, 2012 at 10:37 AM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
>> On Thu, Jan 12, 2012 at 5:53 PM, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
>>> PrimaryKeepaliveMessage is a message type that uses WalSndrMessage.
>>> That message type is only sent when the WalSndr is quiet, so what is
>>> the difference, in that case?
>> Oh, you are right. There is no difference.
> Here are the changes we discussed. Further comments before commit?

Can you add the test for avoiding useless call of GetReplicationApplyDelay()
and GetReplicationTransferLatency()?


Fujii Masao
NTT Open Source Software Center

In response to

pgsql-hackers by date

Next:From: YAMAMOTO TakashiDate: 2012-01-13 04:24:12
Subject: gistVacuumUpdate
Previous:From: Nick RooseveltDate: 2012-01-13 04:07:04
Subject: Postgres ReviewFest Patch: URI connection string support for libpq

pgsql-committers by date

Next:From: Simon RiggsDate: 2012-01-13 13:01:05
Subject: pgsql: Minor but necessary improvements to WAL keepalives
Previous:From: Alex HunsakerDate: 2012-01-13 02:28:22
Subject: Re: [COMMITTERS] pgsql: Fix breakage from earlier plperl fix.

Privacy Policy | About PostgreSQL
Copyright © 1996-2018 The PostgreSQL Global Development Group