Re: Re: [COMMITTERS] pgsql: Send new protocol keepalive messages to standby servers.

From: Simon Riggs <simon(at)2ndQuadrant(dot)com>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Re: [COMMITTERS] pgsql: Send new protocol keepalive messages to standby servers.
Date: 2012-01-12 19:19:54
Message-ID: CA+U5nM+x6SWfRPF1ntgWwkFfaEAR8gp+x4S9kBsFo2zbh5+EGg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Thu, Jan 12, 2012 at 10:37 AM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
> On Thu, Jan 12, 2012 at 5:53 PM, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
>> PrimaryKeepaliveMessage is a message type that uses WalSndrMessage.
>> That message type is only sent when the WalSndr is quiet, so what is
>> the difference, in that case?
>
> Oh, you are right. There is no difference.

Here are the changes we discussed. Further comments before commit?

--
 Simon Riggs                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services

Attachment Content-Type Size
fujii_review_keepalives.v1.patch text/x-patch 1.2 KB

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2012-01-12 21:40:44 pgsql: Fix CLUSTER/VACUUM FULL for toast values owned by recently-updat
Previous Message Tom Lane 2012-01-12 19:18:31 pgsql: Tweak duplicate-index-column regression test to avoid locale sen

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2012-01-12 19:21:31 Re: pgbench post-connection command
Previous Message Tom Lane 2012-01-12 18:59:49 Re: create index regression fail