| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | Peter Smith <smithpb2250(at)gmail(dot)com> |
| Cc: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: DOCS - "\d mytable" also shows any publications that publish mytable |
| Date: | 2026-01-22 03:24:37 |
| Message-ID: | CAHGQGwG_HdtvQT4Cag+Mq_ObNRUGC3NQ5BzX0mQYOXoHt8rL7Q@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jan 21, 2026 at 7:39 AM Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
>
> Ping. I thought this small DOCS patch had reached some consensus, but
> then the thread went silent for more than 2 weeks.
>
> So, I created a new CF entry [1] marked "ready for committer". Is
> there anything else I need to do to help get this one over the line?
- table, the view definition if the relation is a view, a non-default
- <link linkend="sql-altertable-replica-identity">replica
- identity</link> setting and the
+ table, any partition tables, the view definition if the relation is a
+ view, a non-default <link linkend="sql-altertable-replica-identity">
+ replica identity</link> setting and the
This part doesn't seem to list all possible objects, so it would be better to
add wording like "for example" or "such as".
If this is meant to be illustrative rather than exhaustive, I'm not sure
we need to add a new item like "any partition tables" this time here.
Regarding whole patch, I'm not clear about whether this patch is worthwhile
if it only adds phrasing like "such as" or "for example". That said, if some
users currently interpret the list as exhaustive, this change could help
clarify the intent...
If we decide to commit this change, it seems fine not to backpatch it,
since it's more of a documentation clarification than a clear bug fix.
Regards,
--
Fujii Masao
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Zhijie Hou (Fujitsu) | 2026-01-22 03:38:38 | RE: Newly created replication slot may be invalidated by checkpoint |
| Previous Message | zengman | 2026-01-22 03:21:23 | Re: [PATCH] Align verify_heapam.c error message offset with test expectations |