Re: Documentation fix on pgbench \aset command

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp>
Cc: Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Documentation fix on pgbench \aset command
Date: 2025-09-22 07:19:14
Message-ID: CAHGQGwGY+0QnDU2at3FmnX8PE_1ZXu+7m2zkwUg4augMWHsgNg@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Jun 27, 2025 at 10:37 AM Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp> wrote:
> This will work if we assume that the query never returns the initial value.
> I've attached a updated patch that fix the documentation as below:
>
> If a query returns no rows, no assignment is made. You can detect
> this by initializing the variable beforehand with a value that the query is
> assumed never to return, and then checking whether it changes.

Thanks for updating the patch!

While reviewing the descriptions for \gset and \aset, I noticed they're listed
as a single term. I think it would be clearer to list them separately.
Also, there's no explanation of what happens if the query with \gset returns
zero or multiple rows, so I'd like to add that too. Thought?

I've attached an updated version of the patch with these changes applied.

Regards,

--
Fujii Masao

Attachment Content-Type Size
v3-0001-pgbench-Clarify-documentation-for-gset-and-aset.patch application/octet-stream 2.7 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Banck 2025-09-22 07:22:25 Re: GNU/Hurd portability patches
Previous Message Pavel Stehule 2025-09-22 07:01:46 Re: [PATCH] Introduce unified support for composite GUC options