Re: Make wal_receiver_timeout configurable per subscription

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: Japin Li <japinli(at)hotmail(dot)com>
Cc: Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Make wal_receiver_timeout configurable per subscription
Date: 2026-02-05 14:40:49
Message-ID: CAHGQGwGSzajw7MEusRNvzuTLCOmLG-ond2ZAWrQuDxFhyxLsOQ@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Feb 5, 2026 at 1:06 PM Japin Li <japinli(at)hotmail(dot)com> wrote:
> Thanks for updating the patches.
> I have one small comment on v4-0002:

Thanks for the review!

> @@ -104,6 +105,7 @@ typedef struct SubOpts
> int32 maxretention;
> char *origin;
> XLogRecPtr lsn;
> + char *wal_receiver_timeout;
> } SubOpts;
>
> According to the comment above the SubOpts struct:
>
> Structure to hold a bitmap representing the user-provided CREATE/ALTER
> SUBSCRIPTION command options and the parsed/default values of each of them.
>
> Since `wal_receiver_timeout` is a GUC-style interval value (typically stored as
> integer milliseconds), wouldn't it be better to use an int32 here instead of a
> string?

The wal_receiver_timeout value in CREATE SUBSCRIPTION can include a unit
(for example, 10s), not just a plain integer. Because of that, we can't store it
in an int32, I think.

Regards,

--
Fujii Masao

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2026-02-05 14:55:45 Re: GNU/Hurd portability patches
Previous Message Greg Sabino Mullane 2026-02-05 14:39:53 Re: Pasword expiration warning