Re: [COMMITTERS] pgsql: Add new replication mode synchronous_commit = 'write'.

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: Thom Brown <thom(at)linux(dot)com>
Cc: Kevin Grittner <Kevin(dot)Grittner(at)wicourts(dot)gov>, Robert Haas <robertmhaas(at)gmail(dot)com>, Jaime Casanova <jaime(at)2ndquadrant(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Add new replication mode synchronous_commit = 'write'.
Date: 2012-04-17 19:29:12
Message-ID: CAHGQGwGOoAFsKr31hbQ=qgfNsgFp+N5tQ2E9OwHg=JNhpjkXsg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Tue, Apr 17, 2012 at 9:52 PM, Thom Brown <thom(at)linux(dot)com> wrote:
> On 16 April 2012 17:21, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
>> On Sun, Apr 15, 2012 at 12:13 AM, Thom Brown <thom(at)linux(dot)com> wrote:
>>> No, that's not what I was referring to.  If you don't have a standby
>>> (i.e. a single, isolated database cluster with no replication), and
>>> its synchronous_commit is set to 'remote_write', what effect does that
>>> have?
>>
>> It's the same effect as 'on' and 'local' do, i.e., transaction commit waits
>> for only local WAL flush. This behavior is not documented explicitly...
>> How should we change the document? What about adding the following
>> into the explanation of synchronous_commit parameter (maybe the end
>> of second paragraph of that)?
>>
>> -----------------
>> If synchronous_standby_names is not set, on, remote_write and local
>> provide the same synchronization level; transaction commit only waits for
>> local flush.
>> -----------------
>
> Yes, that sounds fine.

Okay, patch attached.

Regards,

--
Fujii Masao

Attachment Content-Type Size
synchronous_commit_doc_v1.patch application/octet-stream 716 bytes

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Andrew Dunstan 2012-04-17 22:38:27 pgsql: Don't override arguments set via options with positional argumen
Previous Message Heikki Linnakangas 2012-04-17 13:37:14 pgsql: Don't wait for the commit record to be replicated if we wrote no

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2012-04-17 19:30:39 Re: Parameterized-path cost comparisons need some work
Previous Message Kevin Grittner 2012-04-17 19:27:21 extension allocating shared memory