Re: BUG #19881: CLUSTER uses a disabled sort path when enable_sort is off

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: Raja Sai pranav <rajasaipranav0(at)gmail(dot)com>
Cc: pgsql-bugs(at)lists(dot)postgresql(dot)org, imchifan8(at)gmail(dot)com
Subject: Re: BUG #19881: CLUSTER uses a disabled sort path when enable_sort is off
Date: 2026-11-21 14:00:02
Message-ID: CAHGQGwGHP7u5YjyVv9N2EgN_6epZR3VQ46+qh6aEZ_ObKUj9VA@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On Sat, Nov 21, 2026 at 4:14 PM Raja Sai pranav
<rajasaipranav0(at)gmail(dot)com> wrote:
> I sent the REL_18_STABLE version a few minutes ago, but my mail client didn't keep it in this thread, so the archive shows it as a separate thread:

Ok. Anyway, thanks for the v18 and docs patches!

Attached are updated versions of all three patches.

For master and v19, I changed the tests to use REPACK, which exercises
the same code as CLUSTER, and moved them before the final cleanup section.

For v18, I added a test case for enable_seqscan and moved the tests before
cleanup to keep the test structure consistent across branches.

For the docs, I moved the GUC descriptions into the B-tree scan method
discussion to clarify their scope. I also clarified that enable_indexscan = off
takes precedence over the other two settings.

I've updated the commit messages as well. The code fix will be backpatched
to v18, while the docs change is for master only.

Barring any objections, I will commit them.

Regards,

--
Fujii Masao

Attachment Content-Type Size
v3-0001-Honor-enable_sort-and-enable_seqscan-in-CLUSTER-a.patch application/octet-stream 5.4 KB
v3-0002-doc-Clarify-scan-method-selection-for-REPACK-and-.patch application/octet-stream 3.0 KB
nocfbot-v3-0001-Honor-enable_sort-and-enable_seqscan-in-CLUSTER-v18.patch application/octet-stream 4.7 KB

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message shihao zhong 2026-11-21 17:30:36 Re: BUG #19858: pg_dump --clean --if-exists fails on NOT VALID domain constraint
Previous Message Raja Sai pranav 2026-11-21 13:55:45 Re: BUG #19875: Foreign-key self-update rejects an accepted implicit I/O cast