Re: [REVIEW] Re: Compression of full-page-writes

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: Rahila Syed <rahilasyed90(at)gmail(dot)com>
Cc: Rahila Syed <rahilasyed(dot)90(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [REVIEW] Re: Compression of full-page-writes
Date: 2014-11-09 13:32:21
Message-ID: CAHGQGwGDP=mR47hgTKG1jLt9vzH+Ma72yCyhBe8KNjGWkoS7UQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, Nov 9, 2014 at 6:41 AM, Rahila Syed <rahilasyed90(at)gmail(dot)com> wrote:
> Hello,
>
>>The patch was not applied to the master cleanly. Could you update the
>> patch?
> Please find attached updated and rebased patch to compress FPW. Review
> comments given above have been implemented.

Thanks for updating the patch! Will review it.

BTW, I got the following compiler warnings.

xlogreader.c:755: warning: assignment from incompatible pointer type
autovacuum.c:1412: warning: implicit declaration of function
'CompressBackupBlocksPagesAlloc'
xlogreader.c:755: warning: assignment from incompatible pointer type

Regards,

--
Fujii Masao

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Magnus Hagander 2014-11-09 14:46:54 Re: Order of views in stats docs
Previous Message Fujii Masao 2014-11-09 13:30:58 Re: BRIN indexes - TRAP: BadArgument