| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | shihao zhong <zhong950419(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Greg Sabino Mullane <htamfids(at)gmail(dot)com> |
| Subject: | Re: [PG19] psql backslash commands fail with translated messages and a non UTF-8 client encoding |
| Date: | 2026-10-14 00:35:58 |
| Message-ID: | CAHGQGwGCVH+Un1jH4vjp7AV-2jHgBaEM4-zX_oW67di6Bbm2cQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Oct 14, 2026 at 3:30 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> I think that restricting things like that would provide a reasonable
> compromise between safety and losing translation altogether.
Matching all three encodings may not be sufficient, since, e.g.,
OUTPUT_CHARSET can also affect the locale encoding?
I'm also not sure whether matching all three is sufficient on Windows.
> where addQueryComment contains the logic to decide whether translation
> is safe and then also adds the comment syntax.
Agreed. If we cannot guarantee the translation's encoding, falling back
to the original English label would preserve it in server logs and
avoid stripping comments during execution.
Regards,
--
Fujii Masao
| From | Date | Subject | |
|---|---|---|---|
| Next Message | surya poondla | 2026-10-14 00:38:59 | Re: WAL_LOG CREATE DATABASE strategy broken for non-standard page layouts |
| Previous Message | Henson Choi | 2026-10-14 00:35:29 | Re: Row pattern recognition |