From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
---|---|
To: | Stephen Frost <sfrost(at)snowman(dot)net> |
Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Tatsuo Ishii <ishii(at)postgresql(dot)org>, Vik Fearing <vik(at)2ndquadrant(dot)fr>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: primary_conninfo missing from pg_stat_wal_receiver |
Date: | 2016-07-07 04:01:51 |
Message-ID: | CAHGQGwGCML4g3Ns6HPKmRVh2NVDPyvBmPpdVmZAARkqnHH5Xdw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Thu, Jul 7, 2016 at 4:43 AM, Stephen Frost <sfrost(at)snowman(dot)net> wrote:
> All,
>
> * Alvaro Herrera (alvherre(at)2ndquadrant(dot)com) wrote:
>> Michael Paquier wrote:
>> > On Wed, Jul 6, 2016 at 7:34 PM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
>> > > I have one question; why do we call the column "conn_info" instead of
>> > > "conninfo" which is basically used in other places? "conninfo" is better to me.
>> >
>> > No real reason for one or the other to be honest. If you want to
>> > change it you could just apply the attached.
>>
>> I was of two minds myself, and found no reason to change conn_info, so I
>> decided to keep what was submitted. If you want to change it, I'm not
>> opposed.
>>
>> Don't forget to bump catversion.
>
> 'conninfo' certainly seems to be more commonly used and I believe is
> what was agreed to up-thread.
+1. So since no one objects to change the column name,
I applied Michael's patch. Thanks!
Regards,
--
Fujii Masao
From | Date | Subject | |
---|---|---|---|
Next Message | Amit Kapila | 2016-07-07 04:29:30 | Re: Hash Indexes |
Previous Message | Peter Eisentraut | 2016-07-07 02:08:15 | Re: [PATCH] Set sgml-basic-offset to 1 in .dir-locals.el |