| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | vignesh C <vignesh21(at)gmail(dot)com> |
| Cc: | Merlin Moncure <mmoncure(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Up to 50x degradation in dblink performance when receiving notice traffic 19 vs 18 |
| Date: | 2026-09-25 04:57:37 |
| Message-ID: | CAHGQGwGCAH12jfKeGSMLHmapeV_GKEcrhwJwd6XoSLw4q2QgSw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Sep 25, 2026 at 1:39 PM vignesh C <vignesh21(at)gmail(dot)com> wrote:
> Thanks for verifying, here is a v2 version
Thanks for the patch!
+1 to calling errhidestmt(true) and errhidecontext(true).
+ /*
+ * Don't log the local statement or context. This runs once for every
+ * message the remote server sends, and LOG passes the default
+ * log_min_error_statement, so each message would otherwise repeat the
+ * whole text of whatever local query is running. The local context only
+ * says where libpq happened to be reading input, not what caused the
+ * message.
+ */
This comment sounds a bit redundant and indirect to me. How about a simpler
one like this?
Omit the local statement and context from each remote message.
They can help identify the caller, but repeating them for every
message could greatly increase log volume.
Regards,
--
Fujii Masao
| From | Date | Subject | |
|---|---|---|---|
| Next Message | shihao zhong | 2026-09-25 05:07:25 | Re: [PATCH] Refactor remaining zero-fill relation extensions to use smgrzeroextend() |
| Previous Message | Trakshan Mishra | 2026-09-25 04:56:52 | Re: Re: Re: [PATCH] Fix segmentation fault caused by reentrancy in RI_Fkey_cascade_del (ri_triggers.c) |