| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | Sami Imseih <samimseih(at)gmail(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, shihao zhong <zhong950419(at)gmail(dot)com> |
| Subject: | Re: Add missing stats_reset column to pg_statio_all_sequences view |
| Date: | 2026-03-13 01:39:36 |
| Message-ID: | CAHGQGwGA5d0uigSj78xCyjPdc+j3V-qvxk=_NfbV6ScOrGQvbQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Mar 13, 2026 at 7:44 AM Sami Imseih <samimseih(at)gmail(dot)com> wrote:
>
> After Creating this thread and the CF entry for it [1], I realized Shihao also
> created [2] yesterday. Sorry about that.
>
> We can stick with 6582 and Shihao can also get author credit.
Thanks to both Shihao and Sami for proposing patches!
Since the two patches are almost the same, I reviewed Sami's patch.
It looks good to me overall. One comment: for the tests added to stats.sql,
it would be better to verify that the stats of the specified sequence are
actually reset by using pg_stat_reset_single_table_counters().
Also, the documentation for pg_stat_reset_single_table_counters() should
mention that it can reset sequence statistics as well.
Regards,
--
Fujii Masao
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2026-03-13 01:49:57 | Re: Streamify more code paths |
| Previous Message | Andrew Jackson | 2026-03-13 01:29:44 | Re: Add Option To Check All Addresses For Matching target_session_attr |