| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
| Cc: | Shinya Kato <shinya11(dot)kato(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: file_fdw: Support multi-line HEADER option. |
| Date: | 2026-01-20 14:16:08 |
| Message-ID: | CAHGQGwG4E84NkTE-q4_LvWKs7C5p76gzzw5QQOuorEoBm=YJFQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jan 20, 2026 at 2:54 PM Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
> I am sorry maybe I didn’t express myself clear. But in v4, this problem is clearer:
>
> 1 - 0001
> ```
> /*
> - * Allow 0, 1, "true", "false", "on", "off", a non-negative integer, or
> - * "match".
> + * Allow 0, 1, "true", "false", "on", "off", an integer greater than or
> + * equal to zero, or "match".
> */
> ```
>
> Here, “0, 1” is a duplicate of “an integer greater than or equal to zero”, so the commend can be simplified as:
Yeah, the latest patch I attached upthread updates this comment and
removes "0, 1" from it.
Regards,
--
Fujii Masao
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bertrand Drouvot | 2026-01-20 14:56:38 | Re: Remove redundant AssertVariableIsOfType uses in pg_upgrade |
| Previous Message | Fujii Masao | 2026-01-20 14:09:51 | Re: file_fdw: Support multi-line HEADER option. |