Re: pgsql: doc: Further clarify how recovery target parameters are applied

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Peter Eisentraut <peter(at)eisentraut(dot)org>, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: doc: Further clarify how recovery target parameters are applied
Date: 2019-11-06 04:48:07
Message-ID: CAHGQGwG2KenPa8hTtQ1opgpgVtMQcQ2oAx_mTkyV0YjgaN5M1w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Tue, Nov 5, 2019 at 10:28 PM Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> wrote:
>
> On 2019-Oct-18, Fujii Masao wrote:
>
> > > Thanks for improving the documentation.
> > >
> > > + In this mode, the parameters from both this section and <xref
> > > + linkend="runtime-config-wal-recovery-target"/> will be used. Parameters
> > > + from <xref linkend="runtime-config-replication-standby"/> will not be
> > > + used.
> > >
> > > The latter description seems not true. hot_standby and
> > > max_standby_archive_delay in "runtime-config-replication-standby"
> > > are used during archive recovery. So something like the following
> > > change would need to be applied, I think. Patch attached.
>
> This has not been applied, right?

Yes.

> Can you send a complete patch?

Thanks for the ping!
Patch attached. As I argued upthread, IMO it's better to remove
the latter description from the doc and the patch does that.
Also the patch adds "mainly" into the former description.

Regards,

--
Fujii Masao

Attachment Content-Type Size
doc_guc_for_standby.patch application/octet-stream 1011 bytes

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Andrew Gierth 2019-11-06 05:01:21 pgsql: Request small targetlist for input to WindowAgg.
Previous Message Fujii Masao 2019-11-06 03:55:36 pgsql: Correct the command tags for ALTER ... RENAME COLUMN.