Re: column name of pg_stat_replication.backend_start

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: column name of pg_stat_replication.backend_start
Date: 2012-04-14 14:39:26
Message-ID: CAHGQGwFyFVHNJZ3AQ-Tt-Lp9Fu+ARThO6aqHTOtX0T=S+ANmxQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Apr 14, 2012 at 10:05 PM, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
> On Sat, Apr 14, 2012 at 14:22, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>> On Sat, Apr 14, 2012 at 8:00 AM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
>>> The column name of pg_stat_replication.backend_start is confusing because
>>> it's not the time when *backend* was started at all. We should rename it to
>>> "walsender_start" or "replication_start"?
>>
>> walsenders are backends, of course.  I think that any clarity we'd get
>> from renaming this would be not worth the loss of backward
>> compatibility or the inconsistency with pg_stat_activity.
>
> There was a suggestion the other day I think from Bruce to rename it
> to session_start in pg_stat_activity. If we do that, we should
> probably rename it in pg_stat_replication *as well*, of course...

Yep, agreed.

Regards,

--
Fujii Masao

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2012-04-14 14:58:12 Re: [COMMITTERS] pgsql: Add new replication mode synchronous_commit = 'write'.
Previous Message Tom Lane 2012-04-14 14:32:57 Re: missing description initdb manual