Re: doc: Reformat SELECT queries using GRAPH_TABLE

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: Koshino Taiki <koshino(at)sraoss(dot)co(dot)jp>
Cc: Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: doc: Reformat SELECT queries using GRAPH_TABLE
Date: 2026-08-25 04:44:35
Message-ID: CAHGQGwFxcf7+189ii8PqaD4KP_CW+UA7w92oWWL4eKK6T5OKnw@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Aug 25, 2026 at 10:33 AM Koshino Taiki <koshino(at)sraoss(dot)co(dot)jp> wrote:
> I put together a v2 patch that follows the approach you suggested:
> keeping GRAPH_TABLE ( on the opening line, moving the whole MATCH
> clause to its own line, and putting COLUMNS on another line, for example:
>
> SELECT customer_name FROM GRAPH_TABLE (myshop
> MATCH (c IS customers)
> -[IS customer_orders]->
> (o IS orders WHERE o.ordered_when = current_date)
> COLUMNS (c.name AS customer_name));

Splitting the path pattern across three lines is really necessary?
Even without doing that, the full MATCH line would still be around
90–100 characters, which seems readable enough.

There is another nearby GRAPH_TABLE example in queries.sgml that
uses a different formatting style. If this patch is also intended to
establish a clearer formatting style for GRAPH_TABLE examples,
isn't it better to adjust that example as well?

Regards,

--
Fujii Masao

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Ajin Cherian 2026-08-25 04:51:58 Re: Per-table resync for logical replication subscriptions
Previous Message surya poondla 2026-08-25 04:20:46 Re: pg_xmin_horizon: a system view of everything pinning the xmin horizon