Re: Logical replication launcher did not automatically restart when got SIGKILL

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: cca5507 <cca5507(at)qq(dot)com>
Cc: shveta malik <shveta(dot)malik(at)gmail(dot)com>, Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Logical replication launcher did not automatically restart when got SIGKILL
Date: 2025-07-25 15:30:02
Message-ID: CAHGQGwFuTCT4OYGy3ep=21O+KzD1UN3TbKuMvouYd0dLiAzngA@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Jul 25, 2025 at 10:53 PM cca5507 <cca5507(at)qq(dot)com> wrote:
>
> > For example, we could add a check like the following to 013_crash_restart.pl.
> > Thoughts?
> >
> > -----------------
> > is($node->safe_psql('postgres',
> > "SELECT count(*) = 1 FROM pg_stat_activity WHERE backend_type =
> > 'logical replication launcher'"),
> > 't',
> > 'logical replication launcher is running after crash');
> > -----------------

Patch attached.
I confirmed that the test fails when applied to a version before
commit b5d084c5353 (i.e., before the bug was fixed), and it passes
on HEAD with the patch applied.

> Agree, but we need note that the logical replication launcher won't be registered in some case. (see ApplyLauncherRegister())

Since 013_crash_restart.pl doesn't set any parameters that would
prevent the logical replication launcher from starting, I think
we don't need to worry about that. No??

Regards,

--
Fujii Masao

Attachment Content-Type Size
v1-0001-Add-regression-test-for-background-worker-restart.patch application/octet-stream 1.5 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Paul A Jungwirth 2025-07-25 15:34:37 Re: PoC: adding CustomJoin, separate from CustomScan
Previous Message Sami Imseih 2025-07-25 15:29:01 Re: track generic and custom plans in pg_stat_statements