| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Thomas Ogrisegg <tom-nic(at)patches(dot)fnord(dot)at>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: PATCH: pg_basebackup (missing exit on error) |
| Date: | 2012-03-28 15:12:26 |
| Message-ID: | CAHGQGwFrnPMhpJZT31J4JtCfSrMJfvgtESQVkjXxHhROd0A3Eg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Mar 28, 2012 at 9:40 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> I think it would make sense to rearrange that so that we don't have
> two tests for ztarfile != NULL; do that test first, and then if it
> fails, do the strcmp after that.
Makes sense.
> Also, if we're going to test the return value of fclose(), shouldn't
> we also be checking the return value of gzclose()?
Yes, we should.
Attached patch does the above two changes.
Regards,
--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
| Attachment | Content-Type | Size |
|---|---|---|
| missing_exit_on_error_in_pgbasebackup_v2.patch | application/octet-stream | 1.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2012-03-28 15:15:01 | Re: Re: [COMMITTERS] pgsql: pg_test_timing utility, to measure clock monotonicity and timing |
| Previous Message | Tom Lane | 2012-03-28 15:06:01 | Re: Re: pg_stat_statements normalisation without invasive changes to the parser (was: Next steps on pg_stat_statements normalisation) |