| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp> |
| Cc: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, Rintaro Ikeda <ikedarintarof(at)oss(dot)nttdata(dot)com>, Jakub Wartak <jakub(dot)wartak(at)enterprisedb(dot)com>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, "slpmcf(at)gmail(dot)com" <slpmcf(at)gmail(dot)com>, "boekewurm+postgres(at)gmail(dot)com" <boekewurm+postgres(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Srinath Reddy Sadipiralla <srinath2133(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
| Subject: | Re: Suggestion to add --continue-client-on-abort option to pgbench |
| Date: | 2025-11-11 15:20:15 |
| Message-ID: | CAHGQGwFm91ucTQvWPud6iJk_zC_iFALjcP14iaVf+SZ0RjFwEQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Nov 11, 2025 at 10:50 AM Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp> wrote:
> I've attached a patch to fix this.
Thanks for reporting the issue and providing the patch!
> If a PGRES_PIPELINE_SYNC is followed by something other than PGRES_PIPELINE_SYNC or NULL,
> it means that another PGRES_PIPELINE_SYNC will eventually follow after some other results.
> In this case, we should reset the receive_sync flag and continue discarding results.
Yes.
+ if (res)
+ {
+ received_sync = false;
+ continue;
Shouldn't we also call PQclear(res) here? For example:
---------------------------
if (PQresultStatus(res) == PGRES_PIPELINE_SYNC)
received_sync = true;
- else if (received_sync)
+ else if (received_sync && res == NULL)
{
- /*
- * PGRES_PIPELINE_SYNC must be followed by another
- * PGRES_PIPELINE_SYNC or NULL; otherwise,
assert failure.
- */
- Assert(res == NULL);
-
/*
* Reset ongoing sync count to 0 since all
PGRES_PIPELINE_SYNC
* results have been discarded.
@@ -3601,6 +3595,8 @@ discardUntilSync(CState *st)
PQclear(res);
break;
}
+ else
+ received_sync = false;
PQclear(res);
---------------------------
Regards,
--
Fujii Masao
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2025-11-11 15:22:38 | Re: Suggestion to add --continue-client-on-abort option to pgbench |
| Previous Message | Álvaro Herrera | 2025-11-11 15:16:08 | Re: [PATCH] Add pg_get_tablespace_ddl() function to reconstruct CREATE TABLESPACE statement |