| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | Peter Smith <smithpb2250(at)gmail(dot)com> |
| Cc: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: DOCS - "\d mytable" also shows any publications that publish mytable |
| Date: | 2026-01-23 02:40:58 |
| Message-ID: | CAHGQGwFhkhdK79fTeYEnxxfgmzjjshfXuBBnfwoD7GneEdBokQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Jan 22, 2026 at 3:15 PM Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
> > Regarding whole patch, I'm not clear about whether this patch is worthwhile
> > if it only adds phrasing like "such as" or "for example". That said, if some
> > users currently interpret the list as exhaustive, this change could help
> > clarify the intent...
> >
>
> Yes. The patch is not doing much now, but OTOH the reason for this
> patch adding the "missing" publication entry in the first place was
> precisely because I thought the docs page was was documenting
> exhaustive lists; so there might be some merit to clear up that
> illusion.
OK, let's commit the patch as a documentation improvement to
reduce user confusion.
> PSA v4.
Thanks for updating the patch! I've applied a few small tweaks and
attached an updated version.
+ Associated objects, such as indexes, constraints, rules, publications,
+ triggers, and so on, are also shown. For foreign tables, the
I removed "and so on" because using both "such as" and "and so on"
in the same sentence felt redundant.
+ more information is displayed, such as: any comments associated with
I removed "such as" and instead added "for example" before "any comments",
which felt more natural here at least for me.
- identity</link> setting and the
+ identity</link> settings and the
I'm not sure this change is necessary, so I restored the original wording.
I also updated the commit message.
Regards,
--
Fujii Masao
| Attachment | Content-Type | Size |
|---|---|---|
| v5-0001-doc-Clarify-that-d-and-d-output-lists-are-illustr.patch | application/octet-stream | 2.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Chao Li | 2026-01-23 02:41:40 | Re: Refactor recovery conflict signaling a little |
| Previous Message | Ashutosh Bapat | 2026-01-23 02:34:18 | Re: Remove PG_MMAP_FLAGS |