| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | furuyao(at)pm(dot)nttdata(dot)co(dot)jp, Andres Freund <andres(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_receivexlog add synchronous mode |
| Date: | 2014-08-12 09:27:58 |
| Message-ID: | CAHGQGwFh44YO45HfndaREPLOi0mxATFD9AANKFW5Yd0NDk5BmQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Aug 12, 2014 at 4:34 PM, Michael Paquier
<michael(dot)paquier(at)gmail(dot)com> wrote:
> On Fri, Aug 8, 2014 at 5:10 PM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
>> Thanks for the review! Applied the patch.
> I noticed that the tab padding for the new option -F in the getops
> switch is incorrect. Attached patch corrects that. pgindent would have
> caught that anyway, but it doesn't hurt to be correct now.
Yeah, that's a problem. But, as you clearly said, upcoming pgindent
would fix this kind of problem. So I'm not sure if it's really worth fixing
only this case independently.
Regards,
--
Fujii Masao
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Shigeru Hanada | 2014-08-12 09:34:51 | Re: Optimization for updating foreign tables in Postgres FDW |
| Previous Message | furuyao | 2014-08-12 09:19:58 | pg_receivexlog --status-interval add fsync feedback |