Re: invalid number of sync standbys in synchronous_standby_names

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: invalid number of sync standbys in synchronous_standby_names
Date: 2016-12-16 17:26:49
Message-ID: CAHGQGwFfz3EiD=qL8=xC_BuC=4z0kAgGpu-sVvvuje2NcNWhuA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Dec 17, 2016 at 1:00 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Fujii Masao <masao(dot)fujii(at)gmail(dot)com> writes:
>> When the number of sync standbys is set to 0 in s_s_names, the assersion
>> failure happens as follows. This means that current multiple syncrep code
>> assumes that the num of sync standbys must be greater than 0. But we forgot
>> to forbid users from setting that num to 0. This is an oversight in multiple
>> syncrep patch (so my fault...). Attached patch forbits that.
>
> Ooops. Patch looks fine to me.

Thanks for the review! Pushed.

Regards,

--
Fujii Masao

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2016-12-16 17:28:24 Re: PSQL commands: \quit_if, \quit_unless
Previous Message David G. Johnston 2016-12-16 17:21:35 Re: PSQL commands: \quit_if, \quit_unless