| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | Pierre Forstmann <pierre(dot)forstmann(at)gmail(dot)com> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org, Christophe Pettus <xof(at)thebuild(dot)com> |
| Subject: | Re: [Patch] Don't stop a `vacuumdb --all` on a connection failure |
| Date: | 2026-10-30 17:15:15 |
| Message-ID: | CAHGQGwFfgBQHAAjO3Tb+-amSHrh+LhMD-jOPEDc6PA1yxuWTSg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Aug 31, 2026 at 10:42 PM Pierre Forstmann
<pierre(dot)forstmann(at)gmail(dot)com> wrote:
> The new status of this patch is: Ready for Committer
I have a few questions about the proposed behavior.
vacuumdb already exits with status 0 when VACUUM skips tables with a warning
due to, e.g., insufficient privileges, as long as no other errors occur.
So, could we treat skipped databases the same way and make this the default,
without adding a new --continue option?
*If* we do need an option, --continue sounds broader than its actual scope.
Using the prefix --skip for the option name is better, following the naming of
the existing option --skip-locked?
Also, additional connections for --jobs still use fail_ok=false in
connect_slot(). So, --continue can still abort the entire run
if an additional connection fails, for example, due to a database connection
limit. Is this intentional?
Regards,
--
Fujii Masao
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Greg Burd | 2026-10-30 17:21:03 | Re: Hash index: stop registering pin-only bucket pages in WAL (remove REGBUF_NO_CHANGE) |
| Previous Message | Greg Burd | 2026-10-30 17:14:43 | Re: Expanding HOT updates for expression and partial indexes |