| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | Xuneng Zhou <xunengzhou(at)gmail(dot)com> |
| Cc: | shveta malik <shveta(dot)malik(at)gmail(dot)com>, Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Hugo DUBOIS <hdubois(at)scaleway(dot)com>, pgsql-bugs(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Unexpected Standby Shutdown on sync_replication_slots change |
| Date: | 2025-08-04 11:59:26 |
| Message-ID: | CAHGQGwFd1Lajx3kr2dRo=wJGF90m4tcEAXoW3s45RQpk+Sb0YQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Sat, Aug 2, 2025 at 1:28 PM Xuneng Zhou <xunengzhou(at)gmail(dot)com> wrote:
> This fix does feel more like an enhancement to user feedback and
> safety nets, not a correction of a broken or unsafe code path. Unable
> to start up with the same settings for it might cause
> more-than-necessary surprise.
Agreed.
At first, since there seems to be rough consensus on applying the current patch
(which prevents unexpected shutdown while the server is running),
I've pushed it to master and back-patched it to v17.
As for the follow-up change that prevents the server from starting with
an invalid configuration, let's continue the discussion. I've attached
the patch and agree it's a good fit for master. However, I'm afraid
it's too late to include it in v18, as beta2 has already been released
and this change is more of an improvement than a bug fix.
Regards,
--
Fujii Masao
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-Disallow-server-start-with-sync_replication_slots.patch | application/octet-stream | 1.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | PG Bug reporting form | 2025-08-04 12:14:36 | BUG #19009: Empty repomd.xml.asc file on pgdg16 mirror causes metadata retrieval failure |
| Previous Message | Daniil Davydov | 2025-08-04 11:08:44 | Re: BUG #16961: Could not access status of transaction |