Re: pg_restore --no-policies should not restore policies' comment

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: jian he <jian(dot)universality(at)gmail(dot)com>
Cc: Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_restore --no-policies should not restore policies' comment
Date: 2025-09-18 03:03:24
Message-ID: CAHGQGwFcjccSYX+Ap8meEbCccUei-B4tmYsBFu4wMEixKi90fQ@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Sep 16, 2025 at 5:04 PM Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
>
> On Tue, Sep 9, 2025 at 4:56 PM Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
> > Thanks for the review! Unless there are any objections,
> > I’ll run the tests again and then push the patches.
>
> I've pushed patches 0001, 0002, and 0003. I'll push 0004 later.

I've pushed 0004, thanks!

> Buildfarm member petalura reported a failure at [1] after 0001 was backpatched
> to v13. However, the server logs show a "double free or corruption" error
> occurring as the backend was exiting. Since that code was not touched by 0001,
> for now I don't think this failure is related to the patch...
> But am I missing something?

After pushing 0004, petalura reported another failure with a "double
free or corruption" error:
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=petalura&dt=2025-09-18%2002%3A14%3A32

Buildfarm member phycodurus also reported similar failures:
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=phycodurus&dt=2025-09-16%2011%3A09%3A07
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=phycodurus&dt=2025-09-16%2016%3A44%3A37

I'll dig deeper into this issue.

As for the unnecessary code for security labels on extensions
you mentioned earlier, I've created a patch to remove it. Patch attached.

Regards,

--
Fujii Masao

Attachment Content-Type Size
v1-0001-pg_dump-Remove-unnecessary-code-for-security-labe.patch application/octet-stream 1.5 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Yugo Nagata 2025-09-18 03:05:06 Re: psql: tab-completion support for COPY ... TO/FROM STDIN, STDOUT, and PROGRAM
Previous Message Michael Paquier 2025-09-18 02:49:11 Re: PgStat_HashKey padding issue when passed by reference