| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
| Cc: | getiancheng <getiancheng_2012(at)163(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Release postmaster working memory context in slotsync worker |
| Date: | 2026-04-06 14:09:49 |
| Message-ID: | CAHGQGwFWLN=-O3A7uBjmgYJt7Q9DMvn05C_aM7HMXg6DiSV_9Q@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Mar 19, 2026 at 5:16 PM Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
> Still, the current phrasing seems a bit too strong to me. Strictly speaking, the memory is already inherited at fork time, so this is not making access impossible in an absolute sense. What this patch really does is remove the inherited PostmasterContext, so the child no longer retains that postmaster-private data through that context.
>
> Maybe we could phrase in some way like: "so that it no longer retains access to postmaster-private data through PostmasterContext”.
Thanks for the review! I've pushed the patch.
Per your and Tiancheng's suggestions, I just used "prevent unintended use"
in the commit message.
Regards,
--
Fujii Masao
| From | Date | Subject | |
|---|---|---|---|
| Previous Message | Bruce Momjian | 2026-04-06 14:05:23 | Re: PG 19 release notes and authors |