Re: CLUSTER progress: wrong index_rebuild_count for tables with TOAST

On Fri, Jun 26, 2026 at 3:46 PM Adam Lee <adam8157(at)gmail(dot)com> wrote:
> The fix is to not report progress for the TOAST index build, because it
> is an internal index, not a user CREATE INDEX. The patch also adds an
> isolation test that pauses CLUSTER at the start of the heap scan and
> checks that index_rebuild_count is 0.

Thanks for the patch!

I think the approach in the patch, i.e., passing INDEX_CREATE_SUPPRESS_PROGRESS
to suppress progress reporting when creating TOAST indexes, looks good.
But, adding that test seems overkill to me. I'd prefer to simplify the patch
as in the attached 0001 patch. Thoughts?

While working on this patch, I also found a related but separate issue:
during REPACK (CONCURRENTLY), index_rebuild_count in
pg_stat_progress_repack and pg_stat_progress_cluster did not advance
as indexes were rebuilt. The attached 0002 patch fixes this issue.

Regards,

--
Fujii Masao