| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pgsql: Reduce log level of some logical decoding messages from LOG to D |
| Date: | 2026-04-07 03:51:32 |
| Message-ID: | CAHGQGwFUbZWXW=y_XFJQatSkW8UFX1js=9g-JoZN9+go_j5KKg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Tue, Apr 7, 2026 at 12:18 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Tue, Apr 7, 2026 at 8:34 AM Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
> >
> > On Tue, Apr 7, 2026 at 1:16 AM Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> > > > But probably are you suggesting making this behavior the default? If yes,
> > > > one straightforward approach to implement that would be to log these messages
> > > > at LOG when AmWalSenderProcess() or AmLogicalSlotSyncWorkerProcess() is true,
> > > > and at DEBUG1 otherwise.
> > >
> > > Yeah.
> >
> > OK, I've prepared a patch to implement this. Patch attached.
> > It introduces a LogicalDecodingLogLevel() macro to choose the log level
> > based on context, but the name may not be ideal, so suggestions are welcome.
> >
>
> How about adding repack_worker to that check as well? See 28d534e2ae.
Thanks for the info!
It may be better to use DEBUG1 when AmRegularBackendProcess() is true
and LOG otherwise, rather than checking AmWalSenderProcess() or
AmLogicalSlotSyncWorkerProcess(). This would also cover any future
background processes that use logical decoding.
Regards,
--
Fujii Masao
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2026-04-07 03:54:41 | Re: pgsql: Reduce log level of some logical decoding messages from LOG to D |
| Previous Message | Amit Kapila | 2026-04-07 03:32:54 | Re: pgsql: Reduce log level of some logical decoding messages from LOG to D |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2026-04-07 03:54:41 | Re: pgsql: Reduce log level of some logical decoding messages from LOG to D |
| Previous Message | Amit Kapila | 2026-04-07 03:48:31 | Re: Use SIGTERM instead of SIGUSR1 for slotsync worker to exit during promotion? |