From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
---|---|
To: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Tab completion support for ALTER SUBSCRIPTION REFRESH PUBLICATION |
Date: | 2017-04-12 14:48:24 |
Message-ID: | CAHGQGwFT+W3HkXFyRHHG6n1j7Xs_W-4CBGBuytuO_pXT7u2p8w@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, Apr 12, 2017 at 5:12 PM, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
> Hi,
>
> I've attached a patch for $subject. Please check it.
+ COMPLETE_WITH_LIST8("WITH", "CONNECTION", "SET PUBLICATION", "ENABLE",
+ "DISABLE", "OWNER TO", "RENAME TO", "REFRESH PUBLICATION WITH");
"WITH" should be "WITH ("?
Also "REFRESH PUBLICATION WITH" should be "REFRESH PUBLICATION WITH ("?
BTW, I found that ALTER SUBSCRIPTION ... RENAME TO exists in tab-complete.c,
but not in the documentation. ALTER PUBLICATION has the same issue, too.
So I think that we need to apply the attached patch which improves the
documentation
for ALTER PUBLICATION and SUBSCRIPTION.
Regards,
--
Fujii Masao
Attachment | Content-Type | Size |
---|---|---|
bugfix.patch | application/octet-stream | 3.3 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Eisentraut | 2017-04-12 14:49:26 | Re: logical replication apply to run with sync commit off by default |
Previous Message | Mithun Cy | 2017-04-12 14:47:59 | Re: TAP tests take a long time |