| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
| Cc: | "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: doc: Clarify that empty COMMENT string removes the comment |
| Date: | 2026-03-03 00:28:56 |
| Message-ID: | CAHGQGwFSxdXh-LsSTj+EE6VhJm6XjpgiH42kUsUDxgXViFn-Cg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Mar 3, 2026 at 8:42 AM Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
>
>
>
> > On Feb 28, 2026, at 09:21, David G. Johnston <david(dot)g(dot)johnston(at)gmail(dot)com> wrote:
> >
> > On Fri, Feb 27, 2026 at 5:12 PM Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
> >
> > PFA v3.
Thanks for updating the patch! LGTM
One more comment: the handling of empty-string comments exists in both
CreateComments() and CreateSharedComments(). For better test coverage,
how about adding also the regression test to check that COMMENT with
empty-string works as expected for shared objects such as roles?
Regards,
--
Fujii Masao
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andy Fan | 2026-03-03 00:45:54 | Re: A out of date comment of WaitForWALToBecomeAvailable |
| Previous Message | Melanie Plageman | 2026-03-03 00:04:24 | Re: eliminate xl_heap_visible to reduce WAL (and eventually set VM on-access) |