Re: CLUSTER progress: wrong index_rebuild_count for tables with TOAST

On Sun, Sep 13, 2026 at 9:52 PM Álvaro Herrera <alvherre(at)kurilemu(dot)de> wrote:
> I agree that the test is overkill -- after all, we don't test any of
> progress reporting, and I'm not sure it's really a great approach to do
> that by adding bespoke injection points.
>
> Your 0001 looks good to me.

Thanks for the review! I've pushed the patch.

> Maybe in a future release we can discuss a framework for making progress
> updates visible in debug builds, so that they can be observed from a
> new test framework.

+1

> > While working on this patch, I also found a related but separate issue:
> > during REPACK (CONCURRENTLY), index_rebuild_count in
> > pg_stat_progress_repack and pg_stat_progress_cluster did not advance
> > as indexes were rebuilt. The attached 0002 patch fixes this issue.
>
> Hmm, yeah, this patch looks good also.

I've pushed this patch as well. Thanks!

Regards,

--
Fujii Masao