| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Staroverov Ilja <i(dot)staroverov(at)ftdata(dot)ru>, Peter Eisentraut <peter(at)eisentraut(dot)org>, "jj-zhang25(at)mails(dot)tsinghua(dot)edu(dot)cn" <jj-zhang25(at)mails(dot)tsinghua(dot)edu(dot)cn>, "pgsql-bugs(at)lists(dot)postgresql(dot)org" <pgsql-bugs(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: BUG #19644: byteaout, float8out and float4out are marked IMMUTABLE but depend on GUCs |
| Date: | 2026-10-21 02:39:43 |
| Message-ID: | CAHGQGwFQ1p7byn6GNz8cZC7G=vSeLXuVdbLT979zNyx47Q7LsA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Wed, Oct 21, 2026 at 1:18 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> I don't mind marking xpath() as STABLE, but I wonder if doing so for
> quote_ident() would cause performance issues. But a quick look
> through our frontend programs didn't turn up any usages that look
> like they'd be candidates for constant-folding, so maybe it's fine.
So, simply marking quote_ident() as STABLE seems better to me.
Attached 0003 patch marks both xpath() overloads and quote_ident()
as STABLE.
I'm also attaching v2 of the cube and hstore patches.
The cube patch is unchanged from v1. The hstore patch removes the
unnecessary test.
Regards,
--
Fujii Masao
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0003-Mark-xpath-and-quote_ident-as-STABLE.patch | application/octet-stream | 3.9 KB |
| v2-0001-cube-Mark-cube_out-as-STABLE.patch | application/octet-stream | 2.7 KB |
| v2-0002-hstore-Mark-hstore-record-and-populate_record-as-.patch | application/octet-stream | 3.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Staroverov Ilja | 2026-10-21 04:40:22 | Re: BUG #19644: byteaout, float8out and float4out are marked IMMUTABLE but depend on GUCs |
| Previous Message | shihao zhong | 2026-10-21 01:20:18 | Re: BUG #19760: CLUSTER loses a row the transaction inserted and then updated in a rolled-back subtransaction |