Re: BUG #19776: pg_combinebackup ignores the truncation_block_length of an intermediate incremental backup

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: Raja Sai pranav <rajasaipranav0(at)gmail(dot)com>
Cc: rajeshkumarth(at)google(dot)com, pgsql-hackers(at)lists(dot)postgresql(dot)org, kehan5800(at)gmail(dot)com, robertmhaas(at)gmail(dot)com, dilipkumarb(at)google(dot)com
Subject: Re: BUG #19776: pg_combinebackup ignores the truncation_block_length of an intermediate incremental backup
Date: 2026-11-19 07:14:21
Message-ID: CAHGQGwFOXYNnyLN4A_PDpRVyt9WqhhsjgG2akfsB90BnWJLxwA@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

On Wed, Nov 18, 2026 at 10:05 PM Raja Sai pranav
<rajasaipranav0(at)gmail(dot)com> wrote:
> Both look good to me. Which to take is Fujii-san's call, but I'd include 0002, since it doesn't depend on COPY batching or shared_buffers.

I've pushed the 0001 patch first. The new test seems to address
the concern I raised, but I'd like more time to assess the approach
of manipulating files directly.

BTW, regarding the discussion on the list, could you avoid top-posting?
Bottom-posting is the preferred style on this mailing list.

Regards,

--
Fujii Masao

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Henson Choi 2026-11-19 07:22:28 Re: BUG #19911: Window aggregate over ROWS n FOLLOWING: "unexpected end of tuplestore" after spill
Previous Message PG Bug reporting form 2026-11-19 06:44:17 BUG #19923: SEARCH/CYCLE with DISTINCT in the recursive term: rows depend on input order

Browse pgsql-hackers by date

  From Date Subject
Next Message Fujii Masao 2026-11-19 07:19:07 Re: Fix resource leaks in pg_receivewal on LZ4 close failures
Previous Message Jim Jones 2026-11-19 07:12:56 Re: Fix ISSN output truncation when the issue code is nonzero