Re: Suggestion to add --continue-client-on-abort option to pgbench

On Fri, Nov 14, 2025 at 4:45 PM Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
> ```
> + else if (received_sync && res == NULL)
> {
> - /*
> - * PGRES_PIPELINE_SYNC must be followed by another
> - * PGRES_PIPELINE_SYNC or NULL; otherwise, assert failure.
> - */
> - Assert(res == NULL);
> -
> /*
> * Reset ongoing sync count to 0 since all PGRES_PIPELINE_SYNC
> * results have been discarded.
> @@ -3601,6 +3610,15 @@ discardUntilSync(CState *st)
> PQclear(res);
> break;
> }
> ```
>
> As we now add “res==NULL” to the “else if”, once entering "else if (received_sync && res == NULL)”, res must be NULL, so "PQclear(res);” should be deleted.

OK, the PQclear() there is unnecessary, so I removed it in the patch I
posted earlier.

Regards,

--
Fujii Masao