Re: psql \watch versus \timing

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Cc: Bruce Momjian <bruce(at)momjian(dot)us>, Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: psql \watch versus \timing
Date: 2014-10-23 13:35:00
Message-ID: CAHGQGwFGB4x9XK7mrxLUngN+odkbAKOcHceXx161_AXJc1ydpg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Oct 14, 2014 at 8:11 AM, Michael Paquier
<michael(dot)paquier(at)gmail(dot)com> wrote:
> On Tue, Oct 14, 2014 at 4:49 AM, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
>> On Thu, Sep 4, 2014 at 10:50:58PM +0900, Michael Paquier wrote:
>>> On Thu, Sep 4, 2014 at 1:44 PM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
>>> > On Thu, Aug 28, 2014 at 8:46 PM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
>>> >> Good catch. So I will remove start_xact code later.
>>> > Attached patch removes start_xact from PSQLexec.
>>> Nothing negative to say here :)
>>> Patch simply removes the second argument of PSQLexec that was set to
>>> the same value everywhere, aka false as noticed by Heikki. Comments
>>> and code blocks related to this parameter are removed, and the code
>>> compiles, passing check-world as well (just kicked the tests in case).
>>
>> Uh, where are we on this? Should I commit it?
> The patch cleaning up the dead code of psql could be clearly applied
> now. For the feature itself not sure, it may be better to let
> Fujii-san manage it.

Applied.

Regards,

--
Fujii Masao

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2014-10-23 13:39:50 Re: idea: allow AS label inside ROW constructor
Previous Message Merlin Moncure 2014-10-23 13:27:25 Re: idea: allow AS label inside ROW constructor