Re: [BUG] Take a long time to reach consistent after pg_rewind

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: Xuneng Zhou <xunengzhou(at)gmail(dot)com>
Cc: surya poondla <suryapoondla4(at)gmail(dot)com>, cca5507 <cca5507(at)qq(dot)com>, solai v <solai(dot)cdac(at)gmail(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: [BUG] Take a long time to reach consistent after pg_rewind
Date: 2026-11-20 12:05:39
Message-ID: CAHGQGwFG9Q4u+xDUe9YArVwyMktQKztkFuY+jbsnXUsyQ847qA@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Nov 20, 2026 at 5:19 PM Xuneng Zhou <xunengzhou(at)gmail(dot)com> wrote:
> +1 for backpatching and v5 LGTM.

Thanks for the review! I've pushed the patch.

> Do we need a regression test for this
> issue in master? It seems that 24723e7cf39, b1f14c96720 and the
> $subject all suffer from the extra header skipping of
> pg_current_wal_insert_lsn()/GetXLogInsertRecPtr().

So you're suggesting adding tests to verify that some operations such as
WAIT FOR and pg_rewind handle the extra header situation correctly?

Regards,

--
Fujii Masao

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message shveta malik 2026-11-20 12:08:52 Re: Proposal: Conflict log history table for Logical Replication
Previous Message Amit Langote 2026-11-20 12:00:37 Re: [PATCH]Fix planner's strictness check for JsonExpr