| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Subject: | Re: Speedup of relation deletes during recovery |
| Date: | 2018-07-04 18:10:33 |
| Message-ID: | CAHGQGwFA0PLgH73RiNL+4T=eXKgxj3gFmBsNLuKP7CEZA2LMKQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jul 3, 2018 at 11:28 AM, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> On Tue, Jul 03, 2018 at 04:13:15AM +0900, Fujii Masao wrote:
>> OK, so what about the attached patch?
>
> I have been looking at this patch, and this looks in good shape to me
Thanks for the review! So, committed.
> (please indent!).
Hmm.. I failed to find indent issue in my patch... But anyway
future execution of pgindent will fix that even if it exists.
> + * Call smgrclose() in reverse order as when smgropen() is called.
> + * This trick enables remove_from_unowned_list() in smgrclose()
> + * to search the SMgrRelation from the unowned list,
> + * in O(1) performance.
>
> A nit here: with O(1) performance.
I changed the patch accordingly.
> Could it be possible to add an assertion so as isRedo is never enabled
> out of recovery?
I'm not sure if adding such assertion into only the function that
the patch added is helpful. There are many functions having something
like isRedo as an argument.
Regards,
--
Fujii Masao
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2018-07-04 20:04:01 | Re: Legacy GiST invalid tuples |
| Previous Message | Tom Lane | 2018-07-04 17:42:58 | Re: "Access privileges" is missing after pg_dumpall |