Re: Logical replication launcher did not automatically restart when got SIGKILL

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: cca5507 <cca5507(at)qq(dot)com>
Cc: shveta malik <shveta(dot)malik(at)gmail(dot)com>, Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Logical replication launcher did not automatically restart when got SIGKILL
Date: 2025-07-27 05:06:56
Message-ID: CAHGQGwF8nFf9+fDiVR4nW_DCgn_bceaQ33cB=xVA3SiG923ciw@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Jul 26, 2025 at 6:27 PM cca5507 <cca5507(at)qq(dot)com> wrote:
>
> Hi,
>
> The test case seems to have a problem:
>
> We cannot ensure that the SELECT happens after the pg_stat_activity can show the logical replication launcher.

Thanks for the review! You're right. We should use poll_query_until()
instead of safe_psql() to handle this properly.
I've attached an updated patch with that change.

Regards,

--
Fujii Masao

Attachment Content-Type Size
v2-0001-Add-regression-test-for-background-worker-restart.patch application/octet-stream 1.7 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Fujii Masao 2025-07-27 06:00:51 Re: Adding REPACK [concurrently]
Previous Message Robert Treat 2025-07-27 01:59:10 Re: Adding REPACK [concurrently]