Re: Add MERGE and VALUES statements to tab completion for PREPARE

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: Haruna Miwa <miwa(at)sraoss(dot)co(dot)jp>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Add MERGE and VALUES statements to tab completion for PREPARE
Date: 2025-11-10 05:15:20
Message-ID: CAHGQGwF7zy9MTjTJkpGom7ADNxe=CRfhXQvjqgAaXsRM3qGXsw@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Nov 10, 2025 at 9:41 AM Haruna Miwa <miwa(at)sraoss(dot)co(dot)jp> wrote:
>
> Hi,
>
> As described in the manual[1], PREPARE ... AS command supports MERGE and VALUES statements, but current psql's tab completion does not suggest them.
> I created a patch that enables MERGE and VALUES to appear as tab completion suggestions.
>
> What do you think?

+1

Should we suggest "MERGE INTO" instead of just "MERGE",
since INTO always follows MERGE?

Also, how about adding "TABLE" and "WITH" to the suggestions,
similar to the tab-completion for "COPY ("?
SELECT statement can be specified in the PREPARE command,
and it can start with SELECT, TABLE, or WITH [1].

Regards,

[1] https://www.postgresql.org/docs/devel/sql-select.html

Regards,

--
Fujii Masao

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Akshay Joshi 2025-11-10 05:16:40 Re: [PATCH] Add pg_get_policy_ddl() function to reconstruct CREATE POLICY statement
Previous Message Sergey Tatarintsev 2025-11-10 05:14:57 pg_getaddrinfo_all() with hintp=NULL