Re: vacuumdb --missing-stats-only and permission issue

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: Corey Huinker <corey(dot)huinker(at)gmail(dot)com>
Cc: Nathan Bossart <nathandbossart(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: vacuumdb --missing-stats-only and permission issue
Date: 2025-08-23 01:59:43
Message-ID: CAHGQGwF78UFci8POW4x_Obx-67=9pRQ_fYdbq1yPdJfhpNO=Rg@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Aug 23, 2025 at 8:15 AM Corey Huinker <corey(dot)huinker(at)gmail(dot)com> wrote:
>
> On Fri, Aug 22, 2025 at 3:34 PM Nathan Bossart <nathandbossart(at)gmail(dot)com> wrote:
>>
>> On Fri, Aug 22, 2025 at 09:01:36AM -0500, Nathan Bossart wrote:
>> > We'll also need documentation and test updates, of course.
>>
>> Here is an attempt at the docs/tests. I also fixed a couple of small
>> issues in the query.
>>
>> --
>> nathan
>
>
> Good catch on the query change. I like the docs change.
>
> Tests look pretty straightforward. Was expecting one of them to test on a WARNING or not, but that might not be reliable enough to capture.
>
> +1

Thanks for working on this!

I tested by creating many tables with make installcheck and running
vacuumdb --missing-stats-only on the regression database.
Without the patch, the query to find tables to analyze took about 60 ms,
but with the patch it took 18 seconds. That seems too slow,
so probably we'll need to tune the query?

Regards,

--
Fujii Masao

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Nathan Bossart 2025-08-23 03:00:06 Re: vacuumdb --missing-stats-only and permission issue
Previous Message Andres Freund 2025-08-22 23:46:43 Re: make -C src/test/isolation failure in index-killtuples due to btree_gist