Re: Add missing FreeDir in CheckTablespaceDirectory

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Add missing FreeDir in CheckTablespaceDirectory
Date: 2026-10-10 16:05:40
Message-ID: CAHGQGwF5ztNrmL7DP1ux2aqgOho8z8BW8x+modhR5US0izO9XA@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Oct 10, 2026 at 6:09 PM Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
>
> Hi,
>
> While reviewing another patch, I spotted that CheckTablespaceDirectory() in xlogrecovery.c misses to call FreeDir() after AllocateDir(). This seems to be an oversight in 9e4f914b5eba, where CheckTablespaceDirectory() was introduced.

Thanks for the patch! LGTM. I'll apply it next week.

Regards,

--
Fujii Masao

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Greg Burd 2026-10-10 16:14:37 Re: Tepid: selective index updates for heap relations
Previous Message Jonathan S. Katz 2026-10-10 15:52:42 Updated PostgreSQL RC / GA dates