| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | Aidar Imamov <imamovaj22(at)gmail(dot)com> |
| Cc: | Nitin Jadhav <nitinjadhavpostgres(at)gmail(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Disable startup progress timeout during standby WAL replay |
| Date: | 2026-11-20 06:43:18 |
| Message-ID: | CAHGQGwF3GQyZuOKt=haOoRC=Vr7UT612nWW2ePsr+FomwxeZ0g@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Oct 26, 2026 at 10:41 PM Aidar Imamov <imamovaj22(at)gmail(dot)com> wrote:
> I've re-attached Fujii's v1 patch to this message.
> So the CF bot reports the correct status in the UI.
> Nothing else changed in the patch from my side.
Thanks! Attached are the updated patches.
In 0002, I clarified the code comment and added a note explaining that
a standby may report progress during initial crash recovery. The code
change itself is unchanged from v1.
While updating the patch, I found another minor issue.
If log_startup_progress_interval is changed to zero during initial
crash recovery, disable_startup_progress_timeout() skips stopping
the active timer when the server enters standby mode, leaving it to
fire unnecessarily.
Attached 0001 fixes this by removing the setting check from
the disable function. Since this is the minor issue, a master-only fix
might be sufficient. OTOH, backpatching also seems reasonable since
this is a bug. I'm currently leaning toward backpatching through v15.
Regards,
--
Fujii Masao
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-Fix-startup-progress-timeout-cancellation-after-c.patch | application/octet-stream | 1.6 KB |
| v3-0002-Disable-startup-progress-timeout-during-standby-W.patch | application/octet-stream | 3.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Previous Message | Mingjie Gao | 2026-11-20 06:20:39 | Re: [PATCH v1] Fix initial sync of zero-column published tables |