Re: Fix publisher-side sequence permission reporting

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Cc: Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Tristan Partin <tristan(at)partin(dot)io>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Fix publisher-side sequence permission reporting
Date: 2026-07-08 09:19:44
Message-ID: CAHGQGwEyrznjGVSNzSdzpdq-n9u=xGeTqZu236A2kFvmzsARtA@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Jul 2, 2026 at 6:55 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> > How about something like this instead?
> >
> > This function returns a row of NULL values if the specified relation
> > OID does not exist, if it is not a sequence, if the current user lacks
> > <literal>SELECT</literal> privilege on the sequence, if the sequence
> > is another session's temporary sequence, or if it is an unlogged
> > sequence on a standby server.
> >
>
> Sounds reasonable. But after this we don't need the next para to say:
> "It requires <literal>SELECT</literal> privilege on the sequence.".
> See attached.

Thanks for the patch! I've pushed it.

> > I've updated the patch furthermore. Attached.
> >
>
> LGTM.

Thanks for the review! I've pushed this as well.

Regards,

--
Fujii Masao

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message shveta malik 2026-07-08 09:28:15 Re: Support EXCEPT for TABLES IN SCHEMA publications
Previous Message Amit Kapila 2026-07-08 09:09:51 Re: [PATCH] Preserve replication origin OIDs in pg_upgrade