| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Clear base backup progress reporting on error |
| Date: | 2026-07-05 23:37:19 |
| Message-ID: | CAHGQGwEwt8wTWMPr7Xt5wBAn-FnVEHRwVbxc2AxiVZDEAbezWg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Jul 4, 2026 at 11:17 PM Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
> This has upset the ABI compliance checker (see <https://buildfarm.postgresql.org/cgi-bin/show_failures.pl?max_days=3&stage=abi-compliance-check&filter=Submit> . Looks like you need to update the .abi-compliance-history file on the affected back branches.
Thanks for pointing out this! That's my mistake...
The ABI break was caused by removing the external function
basebackup_progress_done(). I think the better fix for the stable branches
is to restore that function, even though PostgreSQL core itself no longer
uses it, rather than updating the .abi-compliance-history file. Because
some external backup tools may still be calling basebackup_progress_done().
Thoughts?
Regards,
--
Fujii Masao
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2026-07-05 23:39:42 | Re: Fixing MSVC's inability to detect elog(ERROR) does not return |
| Previous Message | Heikki Linnakangas | 2026-07-05 23:21:56 | Re: pg_dump: use threads for parallel workers on all platforms |