| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Andrey Lepikhov <a(dot)lepikhov(at)postgrespro(dot)ru>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Julien Rouhaud <rjuju123(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, vignesh C <vignesh21(at)gmail(dot)com> |
| Subject: | Re: pg_waldump and PREPARE |
| Date: | 2019-11-12 08:53:02 |
| Message-ID: | CAHGQGwErPbsyqF8jb1FOnpS0RhSPRBJYeLtd2RkX--7_jWRw0A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Nov 11, 2019 at 4:16 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Mon, Nov 11, 2019 at 01:21:28PM +0900, Fujii Masao wrote:
> > Thanks for the review! You are right.
> > I fixed this issue in the attached patch.
>
> The proposed format looks fine to me. I have just one comment. All
> three callers of standby_desc_invalidations() don't actually need to
> print any data if there are zero messages, so you can simplify a bit
> xact_desc_commit() and xact_desc_prepare() regarding the check on
> parsed.nmsgs, no?
Thanks for the review! But probably I failed to understand your point...
Could you clarify what actual change is necessary? You are thinking that
the check of "parsed.nmsgs >= 0" should be moved to the inside of
standby_desc_invalidations()?
Regards,
--
Fujii Masao
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2019-11-12 08:55:19 | Re: [HACKERS] Block level parallel vacuum |
| Previous Message | Daniel Gustafsson | 2019-11-12 08:47:47 | Re: Monitoring disk space from within the server |