| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pgbench: make verbose error messages thread-safe |
| Date: | 2026-05-14 03:34:34 |
| Message-ID: | CAHGQGwEqFLPBvNML8qSJL6GZ=pYWT4SraJ3ZUn-1_77f+A9jdw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Apr 24, 2026 at 8:23 PM Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
>
> On Fri, Apr 24, 2026 at 6:06 PM Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
> > I am not too worried about that, because this code path is only used with --verbose-errors and only when printing error messages. In that situation, the cost of one extra memory allocation per log line should be much smaller than the I/O cost of writing the log message itself. So I think the simpler fix is probably acceptable.
>
> Yes, I feel the same way.
I've pushed the patch. Thanks!
Regards,
--
Fujii Masao
| From | Date | Subject | |
|---|---|---|---|
| Next Message | wenhui qiu | 2026-05-14 03:59:47 | Re: Experimental patch for terminating VACUUM freeze blockers |
| Previous Message | Nathan Bossart | 2026-05-14 03:10:28 | Re: Vacuumlo improvements |