Re: [PATCH] Add missing \ddp psql command

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: David Christensen <david(at)endpoint(dot)com>
Cc: PostgreSQL-development Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Add missing \ddp psql command
Date: 2015-07-07 14:08:43
Message-ID: CAHGQGwEk_5aLTZb+5MdhHx2revhE+NOpGEmSfrWy2ogbd=wwBA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Jul 7, 2015 at 10:44 PM, David Christensen <david(at)endpoint(dot)com> wrote:
>
>> On Jul 7, 2015, at 3:53 AM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
>>
>> On Tue, Jul 7, 2015 at 2:11 AM, David Christensen <david(at)endpoint(dot)com> wrote:
>>> Quickie patch for spotted missing psql \ddp tab-completion.
>>
>> Thanks for the report and patch!
>>
>> I found that tab-completion was not supported in not only \ddp
>> but also other psql meta commands like \dE, \dm, \dO, \dy, \s and
>> \setenv. Attached patch adds all those missing tab-completions.
>
> From a completeness standpoint makes sense to me to have all of them, but from a practical standpoint a single-character completion like \s isn’t going to do much. :)

Sometimes I type TAB after \ to display all the psql meta commands.
Even single-character completion like \s may be useful for that case.
Yeah, I agree that's narrow use case, though.

Regards,

--
Fujii Masao

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2015-07-07 14:17:39 Re: Comfortably check BackendPID with psql
Previous Message Pavel Stehule 2015-07-07 14:04:05 Re: PL/pgSQL, RAISE and error context