Re: Clear base backup progress reporting on error

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Clear base backup progress reporting on error
Date: 2026-07-06 00:52:42
Message-ID: CAHGQGwEkOT_onNDBgAQa8RjoaYGcm0YGnw+zxhPromxgp3+XZA@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Jul 6, 2026 at 8:40 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> Fujii Masao <masao(dot)fujii(at)gmail(dot)com> writes:
> > The ABI break was caused by removing the external function
> > basebackup_progress_done(). I think the better fix for the stable branches
> > is to restore that function, even though PostgreSQL core itself no longer
> > uses it, rather than updating the .abi-compliance-history file. Because
> > some external backup tools may still be calling basebackup_progress_done().
>
> +1

I've restored the function in v15 - v18. Thanks!

Regards,

--
Fujii Masao

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Noah Misch 2026-07-06 01:26:42 wait_event_type for WAIT FOR LSN
Previous Message Michael Paquier 2026-07-06 00:33:35 Re: GIN amcheck leaks memory in gin_check_parent_keys_consistency