Re: [BUG] False indication in pg_stat_replication.sync_state

On Fri, Oct 19, 2012 at 10:29 PM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
> On Fri, Oct 19, 2012 at 5:46 PM, Kyotaro HORIGUCHI
> <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> wrote:
>> Ouch! I'm sorry to have sent truly buggy version, please abandon
>> v2 patch sent just before.
>>
>> Added include "access/transam.h" to syncrep.c and corrected the
>> name of XLByteEQ.
>
> Thanks for updating the patch! This looks good to me.
>
>>> Thank you for comment.
>>>
>>> > > I think this patch should be applied for 9.2.2 and 9.1.7.
>>> >
>>> > Looks good to me, though I don't think the source code comment needs
>>> > to be updated in the way the patch does.
>>>
>>> Ok, the patch for walsender.c becomes 1 liner, quite simple.
>>>
>>> However, I've forgotten to treat other three portions in
>>> walsender.c and syncrep.c also does XLogRecPtrIsInvalid(<XLogPtr
>>> which comes from WAL receiver>). This new patch includes the
>>> changes for them.
>
> Good catch.

Does any commiter pick up this?

Regards,

--
Fujii Masao