Re: [bug fix] dblink leaks unnamed connections

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: "Tsunakawa, Takayuki" <tsunakawa(dot)takay(at)jp(dot)fujitsu(dot)com>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, "Peter Eisentraut (peter(dot)eisentraut(at)2ndquadrant(dot)com)" <peter(dot)eisentraut(at)2ndquadrant(dot)com>
Subject: Re: [bug fix] dblink leaks unnamed connections
Date: 2017-03-09 15:41:48
Message-ID: CAHGQGwEgVSiv4VH6qhMpggNmaws6daoW=L2_p=+xQn67X2cwjA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Mar 8, 2017 at 3:52 PM, Tsunakawa, Takayuki
<tsunakawa(dot)takay(at)jp(dot)fujitsu(dot)com> wrote:
> Hello,
>
> dblink fails to close the unnamed connection as follows when a new unnamed connection is requested. The attached patch fixes this.

This issue was reported about ten years ago and added as TODO item.
http://archives.postgresql.org/pgsql-hackers/2007-10/msg00895.php

I agree that this is a bug, and am tempted to back-patch to all the supported
versions. But it had not been fixed in many years since the first report of
the issue. So I'm not sure if it's ok to just treat this as a bug right now and
back-patch. Or we should fix this only in HEAD? Anyway I'd like to hear
more opinions about this.

Regards,

--
Fujii Masao

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2017-03-09 15:44:05 Re: Write Ahead Logging for Hash Indexes
Previous Message Amit Kapila 2017-03-09 15:23:28 Re: Write Ahead Logging for Hash Indexes